Agent extension api - #5281
Merged
Merged
Conversation
added 3 commits
October 20, 2025 15:43
jamadeo
approved these changes
Oct 29, 2025
| if install_script.exists() { | ||
| eprintln!("Installing Node.js..."); | ||
| let output = std::process::Command::new(&install_script) | ||
| .arg("https://nodejs.org/dist/v23.10.0/node-v23.10.0-x64.msi") |
Member
There was a problem hiding this comment.
is there a better url we could use here, "stable" or something like that?
Collaborator
Author
There was a problem hiding this comment.
pinning does feel better, actually. though I doubt we'll ever update this
| eprintln!("Node.js installation completed"); | ||
| } else { | ||
| return Err(ErrorResponse::internal(format!( | ||
| "Node.js installer script not found at: {}", |
Member
There was a problem hiding this comment.
"node.js not detected on system, and no installer script found"
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Blair Allan <Blairallan@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove most of the add to and remove from the code base and use the API. try to do the best for windows and showing things, but eh